Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

query contract by channel #3075

Open
wants to merge 5 commits into
base: dev
Choose a base branch
from
Open

query contract by channel #3075

wants to merge 5 commits into from

Conversation

ylsGit
Copy link
Contributor

@ylsGit ylsGit commented Apr 7, 2023

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md

  • Reviewed Files changed in the github PR explorer

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge PR #XYZ: [title]" (coding standards)

@ylsGit ylsGit marked this pull request as ready for review April 7, 2023 08:46
@codecov-commenter
Copy link

codecov-commenter commented Apr 7, 2023 •
edited
Loading

Codecov Report

Merging #3075 (4672dcd) into dev (8b5fd3c) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

❗ Current head 4672dcd differs from pull request most recent head d052249. Consider uploading reports for the commit d052249 to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##              dev    #3075      +/-   ##
==========================================
- Coverage   36.06%   36.04%   -0.02%     
==========================================
  Files         434      434              
  Lines       45103    45132      +29     
==========================================
+ Hits        16266    16268       +2     
- Misses      27663    27691      +28     
+ Partials     1174     1173       -1
Impacted Files Coverage Δ
x/erc20/keeper/querier.go 44.55% <0.00%> (-17.95%) ⬇️
x/erc20/types/keys.go 0.00% <ø> (ø)

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ylsGit @codecov-commenter